[SYCL] Refactor sycl::vec's operators implementation
#16529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
refactor-vec-ops
branch
from
4dee791 to
59e673d
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
* Don't use `sycl::vec::vector_t`, as it is planned to be removed from the SYCL 2020 (KhronosGroup/SYCL-Docs#676). Note that this implementation is NOT required to use it, so this PR can be merged before the specification change. * Use `ext_vector_type`-based optimized implementation whenever it's available and not on device only.
aelovikov-intel
force-pushed
the
refactor-vec-ops
branch
from
59e673d to
0b224e9
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Jan 6, 2025
I don't see any benefits in that. It's either exactly the same as for device, or old naive implementation, depending on the host compiler. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Jan 7, 2025
steffenlarsen
approved these changes
Jan 8, 2025
steffenlarsen
added a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 16c2c21.
steffenlarsen
added a commit
that referenced
this pull request
Jan 8, 2025
Reverts #16529 due to failure to build on Windows and MacOS in post-commit.
| // `std::array<bool, N>` is different and LLVM annotates its | ||
| // elements with [0, 2) range metadata when loaded, so we need to | ||
| // ensure we generate 0/1 only (and not 2/-1/etc.). | ||
| static_assert((ext_vector<int8_t, 2>{1, 0} == 0)[1] == -1); |
There was a problem hiding this comment.
This does not seem to be a constant expression on Windows and MacOS.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jan 8, 2025
* Don't use `sycl::vec::vector_t`, as it is planned to be removed from the SYCL 2020 (KhronosGroup/SYCL-Docs#676). Note that this implementation is NOT required to use it, so this PR can be merged before the specification change. * Use `ext_vector_type`-based optimized implementation whenever it's available and not on device only. This is a recommit of intel#16529 with an additional `#if __clang_major__ >= 20` guard around `static_assert` on the expression that wasn't constant in clang-19.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 8, 2025
* Don't use `sycl::vec::vector_t`, as it is planned to be removed from the SYCL 2020 (KhronosGroup/SYCL-Docs#676). Note that this implementation is NOT required to use it, so this PR can be merged before the specification change. * Use `ext_vector_type`-based optimized implementation whenever it's available and not on device only. This is a recommit of #16529 with an additional `#if __clang_major__ >= 20` guard around `static_assert` on the expression that wasn't constant in clang-19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::vec::vector_t, as it is planned to be removed from the SYCL 2020 (Remove underspecified vector_t KhronosGroup/SYCL-Docs#676). Note that this implementation is NOT required to use it, so this PR can be merged before the specification change.ext_vector_type-based optimized implementation whenever it's available and not on device only.